Refactor FXIOS-10145 - Update how we are tearing down our tests #22481
Conversation
In teardown methods in test,put super.tearDown to be executed last during teardown
Generated by 🚫 Danger Swift against 5180b1a |
There was a problem hiding this comment.
thank you @cavaevinci for going through all the test files and making the changes 🥳 !! I had two small comments, but everything else looks great.
@clarmso I'll leave you to confirm if there's any issues with the UI test, but it seems it passes bitrise.
...firefox-ios-tests/Tests/ClientTests/OnboardingTests/OnboardingTelemetryDelegationTests.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
thanks @cavaevinci, looks great now! appreciate the work!
we will also need an approval from the automation team cc: @clarmso
| @@ -21,10 +21,6 @@ let websiteWithSearchField = "https://developer.mozilla.org/en-US/" | |||
|
|
|||
| class DragAndDropTests: BaseTestCase { | |||
| // Disable test suite since in theory it does not make sense with Chron tabs implementation | |||
| override func tearDown() { | |||
| XCUIDevice.shared.orientation = UIDeviceOrientation.portrait | |||
There was a problem hiding this comment.
We need to set the device to portrait again or the next tests would be run in landscape.
There was a problem hiding this comment.
@cavaevinci wanted to follow up on this PR, seems like there's one outstanding comment from @clarmso
There was a problem hiding this comment.
@cyndichin ,missed this one,sorry.I will resolve this in next 24 hours.
I can review the |
|
This PR has been automatically marked as stale. Please leave any comment to keep this PR opened. It will be closed automatically if no further update occurs in the next 7 days. Thank you for your contributions! |
github-actions
bot
added
the
stale
|
This pull request has conflicts when rebasing. Could you fix it @cavaevinci? 🙏 |
github-actions
bot
removed
the
stale
|
@cavaevinci unfortunately it seems there are some conflicts now, let me know if you are still interested in working on this PR; otherwise this PR will go stale and you have done great work! |
In teardown methods in test,put super.tearDown to be executed last during teardown
📜 Tickets
Jira ticket
Github issue
💡 Description
In teardown methods in test,put super.tearDown to be executed last during teardown
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)